Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default registry again #409

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

blink1073
Copy link
Contributor

Follow up to #408, had the wrong url

@blink1073 blink1073 added the bug Something isn't working label Sep 26, 2022
@blink1073 blink1073 enabled auto-merge (squash) September 26, 2022 15:09
@blink1073 blink1073 disabled auto-merge September 26, 2022 15:16
@blink1073 blink1073 changed the title Fix default registry again fix default registry again Sep 26, 2022
@blink1073 blink1073 merged commit 33996f2 into jupyter-server:main Sep 26, 2022
@blink1073 blink1073 deleted the fix-default-registry-again branch September 26, 2022 15:16
@jtpio
Copy link
Member

jtpio commented Sep 26, 2022

Thanks @blink1073!

Curious whether you were planning to make a new release with this fix, or wait for more PRs to get in?

Otherwise I'm happy to make a new 0.24.4 release to be able to check whether it fixes #406 with an ongoing (pending) release.

@blink1073
Copy link
Contributor Author

There wasn't a release yet with these changes, people are picking them up by updating their forks. This will be less of an issue when we release from the repo itself. 😄 I'm cutting a new release now.

@jtpio
Copy link
Member

jtpio commented Sep 26, 2022

Thanks for making the release!

This helped fix the pending release (for reference: jupyterlite/jupyterlite#814 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants