Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of twine repository url #403

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

blink1073
Copy link
Contributor

No description provided.

@blink1073 blink1073 added the bug Something isn't working label Sep 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022

Codecov Report

Base: 82.40% // Head: 82.40% // No change to project coverage 👍

Coverage data is based on head (efde998) compared to base (c808d07).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files          21       21           
  Lines        2905     2905           
  Branches      382      382           
=======================================
  Hits         2394     2394           
  Misses        376      376           
  Partials      135      135           
Impacted Files Coverage Δ
jupyter_releaser/cli.py 88.74% <ø> (ø)
jupyter_releaser/tests/test_cli.py 98.96% <ø> (ø)
jupyter_releaser/lib.py 80.82% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 710113f into jupyter-server:main Sep 25, 2022
@blink1073 blink1073 deleted the fix-twine-repo-handling branch September 25, 2022 17:29
@blink1073
Copy link
Contributor Author

blink1073 commented Sep 25, 2022

@meeseeksdev please backport to version2

1 similar comment
@blink1073
Copy link
Contributor Author

@meeseeksdev please backport to version2

blink1073 added a commit to blink1073/jupyter_releaser that referenced this pull request Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants