Use "hatchling version" as a version command where applicable #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 82.93% 82.92% -0.02%
==========================================
Files 21 21
Lines 2866 2869 +3
Branches 374 375 +1
==========================================
+ Hits 2377 2379 +2
Misses 356 356
- Partials 133 134 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
blink1073
force-pushed
the
use-hatch-version
branch
from
6317ac9
to
eb32e63
Compare
ofek
reviewed
Sep 12, 2022
jupyter_releaser/util.py
Outdated
| version_cmd = version_cmd or TBUMP_CMD | ||
| elif "hatchling" in pyproject_text: | ||
| version_cmd = version_cmd or "hatch version" |
There was a problem hiding this comment.
I have no context but you can also do hatchling version if you don't have the full CLI
There was a problem hiding this comment.
Oh good catch, we actually depend on hatchling and not hatch for this library.
blink1073
changed the title
blink1073
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "hatch version" as a default if there is no tbump config.
Will have to wait for #363 to be merged.