Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the input parameter since_last_stable when running a full release #366

Merged

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Aug 22, 2022

Fixes a typo in .github/workflows/full-release.yml, which makes the since_last_stable parameter unusable (and causes the job to fail if the changelog was built using this parameter).

@brichet
Copy link
Contributor Author

brichet commented Aug 22, 2022

The tests are failing because of https://github.com/fastai/ghapi/releases/tag/1.0.1, that warns if GITHUB_TOKEN is not provided.

Opened an issue here #367

@blink1073 blink1073 added the bug Something isn't working label Aug 22, 2022
@blink1073
Copy link
Contributor

Fixes #367

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 6c449c7 into jupyter-server:main Aug 22, 2022
@brichet brichet deleted the fix/full_release_since_last_stable branch October 6, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants