Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hatchling handling #329

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

blink1073
Copy link
Contributor

Fixes issue seen in jupyter/notebook#6448 where releaser tries to use python setup.py --version to get the file, when it should be using hatchling.version.

@blink1073 blink1073 added the bug Something isn't working label Jun 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #329 (d7ed316) into main (5038e71) will increase coverage by 0.03%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   83.86%   83.89%   +0.03%     
==========================================
  Files          19       19              
  Lines        2559     2570      +11     
  Branches      337      341       +4     
==========================================
+ Hits         2146     2156      +10     
+ Misses        296      295       -1     
- Partials      117      119       +2     
Impacted Files Coverage Δ
jupyter_releaser/util.py 69.56% <42.85%> (-0.04%) ⬇️
jupyter_releaser/tests/test_functions.py 99.07% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5038e71...d7ed316. Read the comment docs.

@blink1073 blink1073 merged commit ecb30ec into jupyter-server:main Jun 14, 2022
@blink1073 blink1073 deleted the fix-version-handling-again branch June 14, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants