Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly install NPM Packages #31

Merged
merged 1 commit into from
May 22, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 22, 2021

Follows the same pattern as python packages, part of the work to add releaser to Lumino

@blink1073 blink1073 added this to the 0.1 milestone May 22, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2021

Codecov Report

Merging #31 (1e2355f) into master (9129099) will decrease coverage by 0.12%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   88.51%   88.38%   -0.13%     
==========================================
  Files          15       15              
  Lines        1715     1722       +7     
  Branches      205      208       +3     
==========================================
+ Hits         1518     1522       +4     
- Misses        122      124       +2     
- Partials       75       76       +1     
Impacted Files Coverage Δ
jupyter_releaser/lib.py 75.89% <62.50%> (-0.48%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/util.py 85.00% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f027ee6...1e2355f. Read the comment docs.

@blink1073 blink1073 merged commit 2fa6096 into jupyter-server:master May 22, 2021
@jtpio jtpio deleted the npm-install branch June 22, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants