Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run check-manifest if using setuptools #302

Merged
merged 1 commit into from
Apr 17, 2022

Conversation

blink1073
Copy link
Contributor

Fixes #280

@blink1073 blink1073 added the bug Something isn't working label Apr 17, 2022
@blink1073 blink1073 enabled auto-merge (squash) April 17, 2022 10:06
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2022

Codecov Report

Merging #302 (925962f) into main (703fbbe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   83.86%   83.87%           
=======================================
  Files          19       19           
  Lines        2529     2530    +1     
  Branches      336      336           
=======================================
+ Hits         2121     2122    +1     
  Misses        293      293           
  Partials      115      115           
Impacted Files Coverage Δ
jupyter_releaser/cli.py 91.45% <100.00%> (ø)
jupyter_releaser/util.py 69.59% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703fbbe...925962f. Read the comment docs.

@blink1073 blink1073 merged commit e684f36 into jupyter-server:main Apr 17, 2022
@blink1073 blink1073 deleted the skip-check-manifest branch April 17, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip the check_manifest check if there is not MANIFEST.in fiile
2 participants