Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward python imports for checking with extract_release #268

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Mar 15, 2022

For the quetz-server we need to override the import name with quetz (instead of quetz_server).

It was otherwise impossible to release.

@welcome
Copy link

welcome bot commented Mar 15, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #268 (a48f996) into main (255af24) will decrease coverage by 0.16%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   85.33%   85.16%   -0.17%     
==========================================
  Files          19       19              
  Lines        2386     2387       +1     
  Branches      305      305              
==========================================
- Hits         2036     2033       -3     
- Misses        252      255       +3     
- Partials       98       99       +1     
Impacted Files Coverage Δ
jupyter_releaser/actions/publish_release.py 0.00% <0.00%> (ø)
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 91.48% <100.00%> (+0.03%) ⬆️
jupyter_releaser/lib.py 84.23% <100.00%> (ø)
jupyter_releaser/python.py 74.35% <0.00%> (-5.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ee402...a48f996. Read the comment docs.

@blink1073 blink1073 added the bug Something isn't working label Mar 15, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit bf20b46 into jupyter-server:main Mar 15, 2022
@welcome
Copy link

welcome bot commented Mar 15, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@wolfv wolfv deleted the forward_check_python branch March 15, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants