Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of doctest skip #241

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

blink1073
Copy link
Contributor

It turns out if you invoke an RST file directly you can't skip the doctests even with the doctest glob option, this is a workaround

@blink1073 blink1073 added the bug Something isn't working label Jan 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #241 (b8fe154) into main (51c650e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files          19       19           
  Lines        2336     2336           
  Branches      302      302           
=======================================
  Hits         1988     1988           
  Misses        251      251           
  Partials       97       97           
Impacted Files Coverage Δ
jupyter_releaser/lib.py 83.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c650e...b8fe154. Read the comment docs.

@blink1073 blink1073 merged commit fe2a3ab into jupyter-server:main Jan 17, 2022
@blink1073 blink1073 deleted the really-no-doctest branch January 17, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants