Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the new main default branch #233

Merged
merged 4 commits into from
Dec 31, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Dec 31, 2021

Looks like the default branch has been renamed to main, but some references still need to be updated.

@jtpio jtpio added this to the 0.10 milestone Dec 31, 2021
@jtpio
Copy link
Member Author

jtpio commented Dec 31, 2021

Looks like the CI failure is relevant and related to github-activity not able to find previous entries on the main branch. For example the output is empty when running locally:

$ github-activity jupyter-server/jupyter_releaser --auth <token> --since v0.3.0 --until v0.4.0 --branch main
Running search query:
repo:jupyter-server/jupyter_releaser


Found 11 items, which will take 1 pages
Found 11 items, which will take 1 pages

@blink1073
Copy link
Contributor

Yeah, let's wait for a new release and then update that test to target PRs that are actually on the main branch. It would have been nice if the GitHub API would consider them to be the same branch.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit e8c0840 into jupyter-server:main Dec 31, 2021
@jtpio jtpio deleted the master-refs branch January 1, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants