Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make branch and version spec optional #223

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

blink1073
Copy link
Contributor

Fixes #222

@blink1073 blink1073 added the enhancement New feature or request label Dec 12, 2021
@blink1073 blink1073 added this to the 0.10 milestone Dec 12, 2021
@blink1073 blink1073 requested a review from jtpio December 12, 2021 03:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2021

Codecov Report

Merging #223 (fa8749a) into master (18d0a59) will increase coverage by 0.04%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   85.06%   85.11%   +0.04%     
==========================================
  Files          19       19              
  Lines        2303     2304       +1     
  Branches      292      290       -2     
==========================================
+ Hits         1959     1961       +2     
- Misses        246      247       +1     
+ Partials       98       96       -2     
Impacted Files Coverage Δ
jupyter_releaser/actions/common.py 0.00% <0.00%> (ø)
jupyter_releaser/actions/generate-changelog.py 0.00% <0.00%> (ø)
jupyter_releaser/changelog.py 87.27% <100.00%> (+0.11%) ⬆️
jupyter_releaser/lib.py 83.94% <100.00%> (+0.04%) ⬆️
jupyter_releaser/util.py 73.30% <100.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d0a59...fa8749a. Read the comment docs.

@jtpio
Copy link
Member

jtpio commented Dec 13, 2021

Thanks!

@jtpio
Copy link
Member

jtpio commented Dec 13, 2021

Maybe we can also update the docs to mention the default behavior as a follow-up.

@jtpio jtpio merged commit ea0e6d7 into jupyter-server:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch Should Be Optional
3 participants