-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi python package publishing #201
Conversation
4781898
to
d010cc4
Compare
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 84.85% 84.81% -0.04%
==========================================
Files 19 19
Lines 2271 2272 +1
Branches 280 281 +1
==========================================
Hits 1927 1927
Misses 248 248
- Partials 96 97 +1
Continue to review full report at Codecov.
|
d010cc4
to
ac87aa2
Compare
1e894f6
to
2d6e629
Compare
9d7f567
to
5d53e01
Compare
5d53e01
to
5919c94
Compare
The problem is that no matter if we build packages in separate directories, we install them in a common directory before uploading them to PyPI, so it's useless. I checked that it works fine with jupyverse. |
if name.startswith( | ||
python_package_name | ||
): # FIXME: not enough to know it's the right package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distribution file name is something like my_package-0.1.2.tar.gz
or my_package-0.1.2-py3-none-any.whl
, and we could imagine a package name being my_package
and another one being my_package_2
, and both would match this condition, so this is not great. Maybe we could include the version spec in the condition, but at first sight tests were failing when doing so.
Thanks @davidbrochart for looking into this. |
@@ -4,7 +4,7 @@ runs: | |||
using: "composite" | |||
steps: | |||
- name: install-releaser | |||
uses: jupyter-server/jupyter_releaser/.github/actions/install-releaser@v1 | |||
uses: davidbrochart/jupyter_releaser/.github/actions/install-releaser@fix_multipy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to revert that one (and similar below) to point to the releaser actions.
f509b82
to
2f3c903
Compare
This is ready to be merged, and jupyverse depends on it. Given that the multi-python packages feature is only used by jupyverse AFAIK, I think the current limitation is acceptable, and we can improve it in the future. The limitation is that the package names, given in the form:
must not start with the same name, e.g. something like that wouldn't work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We now build Python packages in separate distribution directories, and upload them to PyPI independently. This also means publishing assets to PyPI and to NPM separately.
Fixes #200