-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip branch setup on publish #192
Conversation
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 19 19
Lines 2273 2273
Branches 280 280
=======================================
Hits 1927 1927
Misses 250 250
Partials 96 96
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
jupyter_releaser/.github/workflows/full-release.yml Lines 41 to 42 in 6dd044a
Edit: never mind this should actually not be related. |
Ah still seeing this issue with the Full Release workflow after syncing the fork with the latest: https://github.com/jtpio/jupyter_releaser/runs/3973150079?check_suite_focus=true |
According to the logs it used |
Publishing a release seems to be failing on repos with a default branch not named
master
at theforwardport-changelog
step.Example run for a repo with
main
as the default branch: https://github.com/jtpio/jupyter_releaser/runs/3951643392?check_suite_focus=trueComparing this workflow:
To a previous successful one:
We see the releaser used to run
git remote show origin
first to retrieve the default branch.Which seems to indicate that it was defaulting to:
jupyter_releaser/jupyter_releaser/util.py
Lines 123 to 128 in 6dd044a
Here:
jupyter_releaser/jupyter_releaser/lib.py
Line 581 in 6dd044a
Probably the
branch
was previously not passed down toforwardport_changelog
(empty).This PR removes the
RH_BRANCH
override which should revert back to the previous behavior (not tested yet)