Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip branch setup on publish #192

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 20, 2021

Publishing a release seems to be failing on repos with a default branch not named master at the forwardport-changelog step.

Example run for a repo with main as the default branch: https://github.com/jtpio/jupyter_releaser/runs/3951643392?check_suite_focus=true

Comparing this workflow:

image

To a previous successful one:

image

We see the releaser used to run git remote show origin first to retrieve the default branch.

Which seems to indicate that it was defaulting to:

def get_default_branch():
"""Get the default remote branch"""
info = run("git remote show origin")
for line in info.splitlines():
if line.strip().startswith("HEAD branch:"):
return line.strip().split()[-1]

Here:

branch = branch or util.get_default_branch()

Probably the branch was previously not passed down to forwardport_changelog (empty).

This PR removes the RH_BRANCH override which should revert back to the previous behavior (not tested yet)

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #192 (da6f240) into master (6dd044a) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          19       19           
  Lines        2273     2273           
  Branches      280      280           
=======================================
  Hits         1927     1927           
  Misses        250      250           
  Partials       96       96           
Impacted Files Coverage Δ
jupyter_releaser/actions/publish_release.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dd044a...da6f240. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member Author

jtpio commented Oct 21, 2021

Ah that might not be enough for the Full Release workflow, as the common setup is also invoked here

- name: Setup
uses: ./.github/actions/common

Edit: never mind this should actually not be related.

@blink1073 blink1073 added the bug Something isn't working label Oct 21, 2021
@blink1073 blink1073 added this to the 0.9 milestone Oct 21, 2021
@blink1073 blink1073 merged commit 6daa3cc into jupyter-server:master Oct 21, 2021
@jtpio jtpio deleted the publish branch October 21, 2021 22:41
@jtpio
Copy link
Member Author

jtpio commented Oct 22, 2021

Ah still seeing this issue with the Full Release workflow after syncing the fork with the latest: https://github.com/jtpio/jupyter_releaser/runs/3973150079?check_suite_focus=true

@jtpio
Copy link
Member Author

jtpio commented Oct 22, 2021

COMMAND: jupyter-releaser forwardport-changelog https://github.com/jupyterlite/xeus-lua-kernel/releases/tag/untagged-db12667508940e81849a --branch master

According to the logs it used master as the default branch so it probably picked it up from the jupyter_releaser repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants