-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CI #182
Refactor CI #182
Conversation
blink1073
commented
Oct 18, 2021
- Use new GitHub feature that allows us to call other actions from composite actions
- Factor out as much logic as possible into actions
- Create a function to set up environment variables in python action helper modules
- Use local actions in workflows instead of targeting a tag
- Easier to reason about, and it is easy to keep forks up to date through the GitHub UI
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 85.92% 84.77% -1.15%
==========================================
Files 17 19 +2
Lines 2252 2273 +21
Branches 276 280 +4
==========================================
- Hits 1935 1927 -8
- Misses 222 250 +28
- Partials 95 96 +1
Continue to review full report at Codecov.
|
@jtpio, mind reviewing this one? Specifically the fact that we would stop targeting the tagged version of actions in our workflows. |
Nice! It indeed makes sense to use local actions, more convenient when testing from a fork. |
Thank! 🚀 |
Ah, it looks like relative links to actions don't work when used from other repos: https://github.com/ipython/ipykernel/pull/788/checks?check_run_id=3943113875 |