Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI #182

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Refactor CI #182

merged 1 commit into from
Oct 19, 2021

Conversation

blink1073
Copy link
Contributor

  • Use new GitHub feature that allows us to call other actions from composite actions
    • Factor out as much logic as possible into actions
  • Create a function to set up environment variables in python action helper modules
  • Use local actions in workflows instead of targeting a tag
    • Easier to reason about, and it is easy to keep forks up to date through the GitHub UI

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #182 (6090e72) into master (3c82022) will decrease coverage by 1.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   85.92%   84.77%   -1.15%     
==========================================
  Files          17       19       +2     
  Lines        2252     2273      +21     
  Branches      276      280       +4     
==========================================
- Hits         1935     1927       -8     
- Misses        222      250      +28     
- Partials       95       96       +1     
Impacted Files Coverage Δ
jupyter_releaser/actions/check_links.py 0.00% <0.00%> (ø)
jupyter_releaser/actions/common.py 0.00% <0.00%> (ø)
jupyter_releaser/actions/draft_changelog.py 0.00% <0.00%> (ø)
jupyter_releaser/actions/draft_release.py 0.00% <0.00%> (ø)
jupyter_releaser/actions/publish_release.py 0.00% <0.00%> (ø)
jupyter_releaser/cli.py 91.30% <ø> (ø)
jupyter_releaser/tee.py 77.77% <0.00%> (-5.15%) ⬇️
jupyter_releaser/util.py 70.14% <0.00%> (-0.30%) ⬇️
jupyter_releaser/python.py 83.33% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c82022...6090e72. Read the comment docs.

@blink1073
Copy link
Contributor Author

@jtpio, mind reviewing this one? Specifically the fact that we would stop targeting the tagged version of actions in our workflows.

@jtpio
Copy link
Member

jtpio commented Oct 19, 2021

Nice! It indeed makes sense to use local actions, more convenient when testing from a fork.

@blink1073 blink1073 merged commit 6cd54f1 into jupyter-server:master Oct 19, 2021
@blink1073 blink1073 deleted the refactor-ci branch October 19, 2021 15:28
@jtpio
Copy link
Member

jtpio commented Oct 19, 2021

Thank! 🚀

@blink1073
Copy link
Contributor Author

Ah, it looks like relative links to actions don't work when used from other repos: https://github.com/ipython/ipykernel/pull/788/checks?check_run_id=3943113875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants