-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle multiple Python packages #176
Handle multiple Python packages #176
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
98e79d2
to
e2e43f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 85.51% 85.86% +0.34%
==========================================
Files 17 17
Lines 2161 2242 +81
Branches 262 276 +14
==========================================
+ Hits 1848 1925 +77
- Misses 220 222 +2
- Partials 93 95 +2
Continue to review full report at Codecov.
|
Nice, thanks @davidbrochart for looking into this! |
I'm wondering:
|
|
Sounds good, what about a
Maybe we should go with this, as it's the simplest. Also this is how it's done in JupyterLab, right? |
Or as a releaser option directly? For example: [tools.jupyter-releaser.options]
python_packages = ["plugins/**", "example_package"] |
Yes, that's what I meant |
dab7443
to
1c6b72e
Compare
Not sure what's happening on Windows 3.9, since it works on all other platforms. |
3f2f9be
to
7fe65f3
Compare
I've been able to release jupyverse and all its plugins with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
03fbf14
to
70b7e45
Compare
hmmm I'm out of ideas. I think I would need a Windows machine with python 3.9 and play with it myself. |
I'm seeing that in the the logs:
The output directory has all |
4b89438
to
dfa0bba
Compare
I think you need to replace |
So now, replacing |
9d46a02
to
a8d01f6
Compare
My bad, this was it @blink1073, thanks a lot! |
4a8290d
to
acec447
Compare
acec447
to
1a50bae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
This is needed e.g. for jupyverse, where each plugin is a Python package.
I just want to open a PR early in order to get feedback. This first commit creates a repo with multiple Python packages in it.
Closes #169