Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up NPM Package Handling #128

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

blink1073
Copy link
Contributor

Better handling of npm workspace packages - pack them all at once and do not print the tags when listing

@blink1073 blink1073 added this to the 0.5 milestone Sep 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #128 (e1c724e) into master (903fd1e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   85.53%   85.52%   -0.02%     
==========================================
  Files          17       17              
  Lines        2102     2093       -9     
  Branches      253      252       -1     
==========================================
- Hits         1798     1790       -8     
+ Misses        213      212       -1     
  Partials       91       91              
Impacted Files Coverage Δ
jupyter_releaser/npm.py 82.22% <100.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903fd1e...e1c724e. Read the comment docs.

@blink1073 blink1073 merged commit 083fff2 into jupyter-server:master Sep 1, 2021
@blink1073 blink1073 deleted the npm-pkg-cleanup branch September 1, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants