Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Generate Changelog Action #126

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Fix Generate Changelog Action #126

merged 1 commit into from
Aug 27, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Aug 27, 2021

  • Require the branch name
  • Fix handling of empty "since" parameter
  • Use env naming standards

@blink1073 blink1073 added the bug Something isn't working label Aug 27, 2021
@blink1073 blink1073 added this to the 0.5 milestone Aug 27, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #126 (5751c65) into master (35213e0) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   85.53%   85.53%           
=======================================
  Files          17       17           
  Lines        2101     2102    +1     
  Branches      253      253           
=======================================
+ Hits         1797     1798    +1     
  Misses        213      213           
  Partials       91       91           
Impacted Files Coverage Δ
jupyter_releaser/actions/generate-changelog.py 0.00% <0.00%> (ø)
jupyter_releaser/changelog.py 88.28% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35213e0...5751c65. Read the comment docs.

@blink1073 blink1073 merged commit 903fd1e into jupyter-server:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants