Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore capture of since parameter #118

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

fcollonval
Copy link
Member

Fixes bug introduced in #116

@blink1073 blink1073 added the bug Something isn't working label Aug 23, 2021
@blink1073 blink1073 added this to the 0.4 milestone Aug 23, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2021

Codecov Report

Merging #118 (2c267d5) into master (e1110b4) will decrease coverage by 0.86%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   86.22%   85.35%   -0.87%     
==========================================
  Files          17       17              
  Lines        2061     2082      +21     
  Branches      244      248       +4     
==========================================
  Hits         1777     1777              
- Misses        195      216      +21     
  Partials       89       89              
Impacted Files Coverage Δ
jupyter_releaser/actions/draft_changelog.py 0.00% <0.00%> (ø)
jupyter_releaser/actions/draft_release.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1110b4...2c267d5. Read the comment docs.

@blink1073 blink1073 merged commit 6758413 into jupyter-server:master Aug 23, 2021
@fcollonval fcollonval deleted the fix/restore-since branch January 6, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants