Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of "since" parameter #110

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

fcollonval
Copy link
Member

Fixes capture of RH_SINCE that was disrupted by #106

Fixes capture of `RH_SINCE` that was disrupted by jupyter-server#106
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #110 (f9f69b1) into master (b1ab320) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   86.34%   86.18%   -0.17%     
==========================================
  Files          17       17              
  Lines        2051     2055       +4     
  Branches      242      244       +2     
==========================================
  Hits         1771     1771              
- Misses        191      195       +4     
  Partials       89       89              
Impacted Files Coverage Δ
jupyter_releaser/actions/draft_release.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0cc8fb...f9f69b1. Read the comment docs.

@blink1073 blink1073 added the bug Something isn't working label Aug 18, 2021
@blink1073 blink1073 added this to the 0.4 milestone Aug 18, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 1d37638 into jupyter-server:master Aug 18, 2021
@fcollonval fcollonval deleted the fix/handling-since branch January 6, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants