Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job definition list UI #93

Merged
merged 7 commits into from
Oct 7, 2022
Merged

Conversation

dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Oct 5, 2022

Fixes #81.

  • Adds AdvancedTable component, which handles pagination, column sorting, and loading state management out-of-the-box.
  • Refactors old list view table to use AdvancedTable.
  • Adds tabs to list view, toggles between jobs list and job definitions list
    • Columns can be added by appending to both the column definition in the ListJobDefinitionsTable component and to the buildJobDefinitionRow() function.
  • Deletes unused notebook jobs navigation components

TODO:

  • add missing properties to Scheduler.IDescribeJobDefinition.
  • discuss which columns to show in list view and add them to this table.
  • add "open job definition detail" logic in notebook-jobs-panel.tsx.

Notes:
I would like to refactor the AdvancedTable further such that the user does not need to provide a renderRow() prop, but instead have the cell render logic be placed in the column definition. See the MUI X GridColDef API for reference.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Binder 👈 Launch a Binder on branch dlqqq/jupyter-scheduler/job-defn-list-ui

@dlqqq
Copy link
Collaborator Author

dlqqq commented Oct 6, 2022

Jason added input path and create time columns. Other columns not included are tracked in #97 and #98.

@dlqqq dlqqq changed the title [WIP] Add job definition UI Add job definition list UI Oct 6, 2022
@dlqqq
Copy link
Collaborator Author

dlqqq commented Oct 7, 2022

Rebased off of main and added functionality to open detail view from the table link.

@dlqqq dlqqq marked this pull request as ready for review October 7, 2022 21:47
@dlqqq dlqqq merged commit 8ecd5fa into jupyter-server:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update list view to show both jobs and job definitions
2 participants