Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jupyter-collaboration by handling RTC prefix in the file paths #541

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Aug 28, 2024

References

Code changes

getSelectedFilePath helper function now uses serviceManager.contents API to check if there is an added “RTC” drive name in the file path and return local path without it.

User-facing changes

Jupyter Scheduler now works when jupyter-collaboration is installed.

Backwards-incompatible changes

None

Testing

Manually tested the following scenarios with jupyter-collaboration installed:

  • Create a Job ✅
  • Create a Job Definition (job with a schedule) ✅
  • Create a job or a job definition with input folder included ✅
  • Create a job from a notebook whose name starts with "RTC:" ✅
Screenshot 2024-08-29 at 11 25 31 AM

@andrii-i andrii-i added the enhancement New feature or request label Aug 28, 2024
@andrii-i andrii-i marked this pull request as ready for review August 28, 2024 17:56
src/index.tsx Outdated Show resolved Hide resolved
@andrii-i andrii-i requested a review from dlqqq August 28, 2024 20:01
Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@dlqqq
Copy link
Collaborator

dlqqq commented Aug 29, 2024

@andrii-i Can you also post a link to the JupyterLab PR that provided the getLocalPath() reference implementation as a comment on this PR?

@andrii-i
Copy link
Collaborator Author

@dlqqq thank you for looking into this. I added links to reference PRs into the PR description.

@sravyasdh
Copy link

sravyasdh commented Aug 29, 2024

Tested the fix by adding the "RTC:" prefix manually too and it works great in all cases. Thanks @andrii-i !

@andrii-i
Copy link
Collaborator Author

Thank you everyone for looking into this.

@andrii-i andrii-i merged commit bfb84b6 into jupyter-server:main Aug 29, 2024
9 checks passed
@andrii-i andrii-i deleted the RTC_fix branch August 29, 2024 19:27
@andrii-i andrii-i added this to the 2.8.0 milestone Aug 29, 2024
@andrii-i andrii-i changed the title Check for and remove "RTC" drive prefix when returning selected file path added by the jupyter-collaboration Support jupyter-collaboration by handling RTC prefix in the file paths Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input Path with Prefix "RTC:" breaking functionality
3 participants