-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support jupyter-collaboration by handling RTC prefix in the file paths #541
Conversation
… from the file path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
@andrii-i Can you also post a link to the JupyterLab PR that provided the |
@dlqqq thank you for looking into this. I added links to reference PRs into the PR description. |
Tested the fix by adding the "RTC:" prefix manually too and it works great in all cases. Thanks @andrii-i ! |
Thank you everyone for looking into this. |
References
Code changes
getSelectedFilePath
helper function now usesserviceManager.contents
API to check if there is an added “RTC” drive name in the file path and return local path without it.User-facing changes
Jupyter Scheduler now works when
jupyter-collaboration
is installed.Backwards-incompatible changes
None
Testing
Manually tested the following scenarios with jupyter-collaboration installed: