Emit telemetry event on "Run job with input folder" checkbox click #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thank you for adding this! |
srdas
approved these changes
May 31, 2024
nsingl00
pushed a commit
to nsingl00/jupyter-scheduler
that referenced
this pull request
Jun 28, 2024
…upyter-server#523) * emit on package_input_folder click * remove unnecessary onChange event inline typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit
create-job.options.package_input_folder.{check/uncheck}on "Run job with input folder" checkbox click. Metric name is proposed because it is semantically in line with metrics already being emitted: 1, 2, 3.Note that by default LogContext is empty so telemetry goes nowhere (Jupyter Scheduler operator needs to overwrite it with a custom logging function to actually use telemetry). So this PR is in line what we are already doing and does not expose Jupyter Scheduler users to anything.