Adds errors, errorsChanged, validation for input field #44

JasonWeill · 2022-09-24T00:04:39Z

Also tightens up the type checking and passes CreateJob as the mode (previously not passed)

This adds the MUI error highlighting and the submit blocking logic requested in #42.

Screen.Recording.2022-09-23.at.5.51.45.PM.mov

github-actions · 2022-09-24T00:04:50Z

👈 Launch a Binder on branch jweill-aws/jupyter-scheduler/error-state

for more information, see https://pre-commit.ci

src/mainviews/create-job.tsx

src/tokens.ts

src/mainviews/create-job.tsx

src/mainviews/list-jobs.tsx

src/tokens.ts

src/mainviews/create-job.tsx

Co-authored-by: Piyush Jain <[email protected]>

Adds errors, errorsChanged

561e576

JasonWeill and others added 4 commits September 23, 2022 17:09

Style updates

db49e74

[pre-commit.ci] auto fixes from pre-commit.com hooks

347199c

for more information, see https://pre-commit.ci

Adds nonblank validation for input file

1aa8373

Adds error indicator

90a9b95

JasonWeill changed the title ~~Adds errors, errorsChanged~~ Adds errors, errorsChanged, validation for input field Sep 24, 2022

awaisabir reviewed Sep 24, 2022

View reviewed changes

src/mainviews/create-job.tsx Show resolved Hide resolved

awaisabir reviewed Sep 24, 2022

View reviewed changes

src/mainviews/create-job.tsx Outdated Show resolved Hide resolved

JasonWeill added 2 commits September 23, 2022 17:55

Adds helper text

72d5102

Renames modelChanged to handleModelChanged

0cf91f7

3coins requested changes Sep 26, 2022

View reviewed changes

JasonWeill and others added 17 commits September 26, 2022 10:13

Rename plugin

ef773f8

Update src/tokens.ts

d36de90

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

a0bbac3

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

2ac7ac8

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

ccb1a1f

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

d0c6017

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

a999c1d

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

0e49702

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

596a8bf

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

10327c2

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

8954353

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/list-jobs.tsx

3de4545

Co-authored-by: Piyush Jain <[email protected]>

Update src/tokens.ts

a989f80

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

97a73cb

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

71114bc

Co-authored-by: Piyush Jain <[email protected]>

Update src/mainviews/create-job.tsx

08c97bf

Co-authored-by: Piyush Jain <[email protected]>

Additional updates per pijain@'s comments

e4029ba

JasonWeill mentioned this pull request Sep 26, 2022

Add full-widget-sized job detail view #46

Closed

Renames button from "Run Now" to "Create"

0da381f

3coins approved these changes Sep 26, 2022

View reviewed changes

JasonWeill merged commit 4b84c5a into jupyter-server:main Sep 26, 2022

JasonWeill mentioned this pull request Sep 28, 2022

Add error handling to extension point API #42

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds errors, errorsChanged, validation for input field #44

Adds errors, errorsChanged, validation for input field #44

JasonWeill commented Sep 24, 2022 •

edited

Loading

github-actions bot commented Sep 24, 2022

Adds errors, errorsChanged, validation for input field #44

Adds errors, errorsChanged, validation for input field #44

Conversation

JasonWeill commented Sep 24, 2022 • edited Loading

github-actions bot commented Sep 24, 2022

JasonWeill commented Sep 24, 2022 •

edited

Loading