Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'icon' prop typing for ConfirmButton component #386

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

andrii-i
Copy link
Collaborator

Fixes 'icon' prop typing for ConfirmButton component.

As mentioned in #383 (comment), ConfirmDialogButton component always uses icon prop as an instantiated element. Passing a class instead (possibility suggested by the use of OverridableComponent & {muiName: string;} type) would cause an error.

<IconButton title={props.name} onClick={_ => setClicked(true)}>
{props.icon}
</IconButton>

Without this PR:
Screenshot 2023-06-15 at 6 36 50 PM
image

With this PR:
Screenshot 2023-06-15 at 6 36 34 PM

@andrii-i andrii-i added the bug Something isn't working label Jun 16, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch andrii-i/jupyter-scheduler/confirm-button-icon-tpying

@andrii-i andrii-i merged commit 6a4136f into jupyter-server:main Jun 16, 2023
@andrii-i andrii-i deleted the confirm-button-icon-tpying branch June 16, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants