Add click handler to mouseDown on confirm button for Safari compatibilty #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
There is no regression in user experience and it works in safari |
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364; alternative to #382 and #383.
Fixes the two-phase button in Safari by attaching a handler to the
mouseDownevent. For some reason, theclickevent doesn't fire when a user clicks on a button made visible as we do, so theblurevent fires every time, even after I make the button focused explicitly.Also tested as working in Firefox. There is a slight change in functionality, since the second phase of the delete or stop button now starts when the user mouses down, not when they click (mouse down and mouse up).
The animation below was captured in Safari.