Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed encoding while reading notebook in some platforms #354

Merged
merged 2 commits into from
May 11, 2023
Merged

Fixed encoding while reading notebook in some platforms #354

merged 2 commits into from
May 11, 2023

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Mar 10, 2023

Fixes #353

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch 3coins/jupyter-scheduler/fix-encoding

@3coins 3coins self-assigned this Mar 10, 2023
@3coins 3coins added the bug Something isn't working label Mar 10, 2023
@3coins 3coins marked this pull request as ready for review March 10, 2023 21:18
@3coins 3coins mentioned this pull request Mar 10, 2023
Closed
dlqqq
dlqqq approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😁

@dlqqq dlqqq merged commit c6b764b into jupyter-server:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees

@3coins 3coins

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scheduler unable to run if the ipynb content contains quotation mark
2 participants
@3coins @dlqqq