Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump binder node version #343

Merged
merged 1 commit into from
Feb 24, 2023
Merged

bump binder node version #343

merged 1 commit into from
Feb 24, 2023

Conversation

dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Feb 24, 2023

Closes #332

@dlqqq dlqqq added the enhancement New feature or request label Feb 24, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jupyter-server/jupyter-scheduler/bump-node

@dlqqq
Copy link
Collaborator Author

dlqqq commented Feb 24, 2023

The Binder link is not working, but its failure seems to be server-side instead of client-side, which hints that this issue is existing behavior not caused by this PR. It looks like the server extension is not getting installed or loaded in Binder. I'll track this in a separate issue; this PR is just to address potential security vulnerabilities associated with not bumping the Node version in Binder.

Screen Shot 2023-02-24 at 2 46 35 PM

Screen Shot 2023-02-24 at 2 46 55 PM

@dlqqq dlqqq merged commit 18fc692 into main Feb 24, 2023
@dlqqq dlqqq deleted the bump-node branch February 24, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependency on NodeJS 14
1 participant