Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create job form #32

Merged
merged 35 commits into from
Sep 22, 2022
Merged

Fix create job form #32

merged 35 commits into from
Sep 22, 2022

Conversation

JasonWeill
Copy link
Collaborator

@JasonWeill JasonWeill commented Sep 22, 2022 •
edited
Loading

WIP change to reinstate create job form functionality

Brian E. Granger and others added 24 commits September 21, 2022 19:38
@JasonWeill
Update theme provider.
651c3ab
@JasonWeill
Test basic MUI components.
a8f2377
@JasonWeill
Working theme adaptation.
71c270d
@JasonWeill
More explorations with MUI.
b6b2fbb
@JasonWeill
Refactoring models.
179f584
@dlqqq @JasonWeill
fix MUI build
6fbc0ab
@dlqqq @JasonWeill
set builder to ^3.4.7
9a06362
@JasonWeill
Fix jobName to update on change
707b38a
@JasonWeill
Adds working job name, input file, output prefix
9144579
@JasonWeill
Reinstate environment picker
44acffd
@JasonWeill
MUI environment picker
986fa6a
@JasonWeill
Reinstates output format picker
d33dbe2
@JasonWeill
Styles dropdown
0ed335b
@JasonWeill
Removes placeholder value
109ffee
@JasonWeill
Adds label
64e1583
@JasonWeill
Working checkboxes
df6a373
@JasonWeill
Cluster for checkboxes
18e66be
@JasonWeill
Adds parameters picker
aec2eb8
@JasonWeill
Removes create-job-form-inputs
8fd68cf
@JasonWeill
Reorders imports
3817091
@JasonWeill
Removes stray junk from rebase
b170b4b
@JasonWeill
More rebase junk
cded1c4
@JasonWeill
Removes log line
06e1006
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f17ba66 
for more information, see https://pre-commit.ci
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jupyter-server/jupyter-scheduler/jweill-fix-create-job-2

@JasonWeill JasonWeill changed the title Jweill fix create job 2 Fix create job form Sep 22, 2022
@JasonWeill JasonWeill marked this pull request as draft September 22, 2022 02:50
@JasonWeill JasonWeill marked this pull request as ready for review September 22, 2022 21:41
@JasonWeill JasonWeill mentioned this pull request Sep 22, 2022
Closed
3coins
3coins approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates. Everything is functional now!

@JasonWeill JasonWeill merged commit fe98ca4 into main Sep 22, 2022
JasonWeill added a commit that referenced this pull request Sep 22, 2022
@JasonWeill
Fix create job form (#32)
7d47003 
Reinstates functionality of the create job form with MUI components
andrii-i pushed a commit that referenced this pull request Sep 22, 2022
@JasonWeill @andrii-i
Fix create job form (#32)
5317b6c 
Reinstates functionality of the create job form with MUI components
@dlqqq dlqqq deleted the jweill-fix-create-job-2 branch February 24, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3coins 3coins 3coins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonWeill @3coins @dlqqq