Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates "Download job files" tooltip in list jobs view #307

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

JasonWeill
Copy link
Collaborator

@JasonWeill JasonWeill commented Nov 15, 2022

Fixes #295. Updates tooltip for consistency with rest of job row: uses sentence case and adds the job name.

Screen Shot 2022-11-14 at 4 24 42 PM

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jweill-aws/jupyter-scheduler/dl-tooltip

@3coins 3coins added the bug Something isn't working label Nov 15, 2022
@JasonWeill JasonWeill merged commit 2514b6d into jupyter-server:main Nov 15, 2022
JasonWeill added a commit to JasonWeill/jupyter-scheduler that referenced this pull request Nov 15, 2022
dlqqq added a commit that referenced this pull request Nov 16, 2022
* migrate to readthedocs documentation

* add UI configuration section to operator's guide

* Update tooltip for consistency with rest of job row (#307)

* Sets display error on edit JD page (#308)

* Adds plugin

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Copy edits per @jweill-aws and @3coins

Co-authored-by: Piyush Jain <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove source map docs until confirmed to work

* elaborate on development uninstall procedure

* Apply suggestions from code review

Additional small copy edits

Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Piyush Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent casing for "Download Job Files" tooltip
2 participants