Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds error wrapper for list queries #288

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

JasonWeill
Copy link
Collaborator

@JasonWeill JasonWeill commented Nov 9, 2022

Fixes #263. Modifies the AdvancedTable component to capture errors on initial load and next/prev page load. These are displayed as alerts above the table's header row.

In the animation below, the getJobDefinitions handler throws an error 90% of the time.

reload-error

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Binder 👈 Launch a Binder on branch jweill-aws/jupyter-scheduler/list-api-error-handling

@JasonWeill JasonWeill added the enhancement New feature or request label Nov 9, 2022
@JasonWeill JasonWeill merged commit f6e3acb into jupyter-server:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling API Errors in Jobs List View UI
3 participants