Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide timezone selector when editing job definition created with utc_only environment #280

Merged
merged 1 commit into from
Nov 4, 2022
Merged

hide timezone selector when editing job definition created with utc_only environment #280

merged 1 commit into from
Nov 4, 2022

Conversation

dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Nov 4, 2022 •
edited
Loading

Fixes #279.

New behavior of edit job definition view:

  • fetches list of environments on initial render
  • sets model timezone and passes utcOnly: true prop to ScheduleInputs component accordingly

Also updates the seed script to use the conda environments in the job definitions.

Screen.Recording.2022-11-04.at.4.13.51.PM.mov

@dlqqq dlqqq added the bug Something isn't working label Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Binder 👈 Launch a Binder on branch dlqqq/jupyter-scheduler/hide-timezone-when-editting-jd

@JasonWeill JasonWeill linked an issue Nov 4, 2022 that may be closed by this pull request
Timezone selector appears when editing job definitions in a UTC-only environment #279
Closed
JasonWeill
JasonWeill approved these changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally successfully

@dlqqq dlqqq merged commit f030c57 into jupyter-server:main Nov 4, 2022
@dlqqq dlqqq deleted the hide-timezone-when-editting-jd branch November 4, 2022 23:46
andrii-i
andrii-i reviewed Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-i andrii-i andrii-i left review comments

@JasonWeill JasonWeill JasonWeill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timezone selector appears when editing job definitions in a UTC-only environment
3 participants
@dlqqq @andrii-i @JasonWeill