Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create LabeledValue UI element, use LabeledValue in Detail View, fix MaxWidth #221

Merged
merged 21 commits into from
Oct 28, 2022
Merged

Create LabeledValue UI element, use LabeledValue in Detail View, fix MaxWidth #221

merged 21 commits into from
Oct 28, 2022

Conversation

andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Oct 28, 2022 •
edited
Loading

Description

  • Introduces a new element LabeledValue to be used for display of non-editable labeled values and propagates its use across Detail View
  • Adds maxWidth='1000px' (x2 of Create Form) to Detail View s.t. form would not become too wide when displayed on ultra-wide displays

Fixes #173

Preview

labeled_value
Screen Shot 2022-10-27 at 5 48 57 PM

andrii-i and others added 21 commits October 27, 2022 17:05
@andrii-i
Add Edit button that leads to CreateJobDefinition
afabe75
@andrii-i
extract readonly-text-field making it variant='standard' (outlined to…
b538f19 
… be used for editable text fields)
@andrii-i
Use ReadonlyTextField or appropriate styling
0810cae
@andrii-i
create LabeledValue and use it in job-detail
2457e4d
@andrii-i
adjust use of LabeledValue
d51f699
@andrii-i
use LabeledValue in JobDefinition
76e2860
@andrii-i
add helper text
adfcf8f
@andrii-i
use LabeledValue
2d17d83
@andrii-i
remove gap
2518027
@andrii-i
remove comment
3e92fde
@andrii-i
remove unused TextField
fa4e9d6
@andrii-i
remove Link
878d8e6
@andrii-i
add id to labeled value
697ab2e
@andrii-i
roll advanced options back
5e54caf
@andrii-i
remove readonly-text-field
6778735
@andrii-i
set maxWidth to 1000px (x2 of Create Job)
bf58406
@andrii-i
update font sizes to use jupyterlab vars
23f32da
@pre-commit-ci @andrii-i
[pre-commit.ci] auto fixes from pre-commit.com hooks
52b17e2 
for more information, see https://pre-commit.ci
@andrii-i
make labeled values tighter
6c5f553
@andrii-i
remove 'Edit' button
802dd88
@andrii-i
rollback CreateJob
08fa35d
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch andrii-i/jupyter-scheduler/detail-view-fixes

This was referenced Oct 28, 2022
Closed
Closed
@andrii-i andrii-i added the enhancement New feature or request label Oct 28, 2022
@andrii-i andrii-i merged commit 81eef81 into jupyter-server:main Oct 28, 2022
@andrii-i andrii-i deleted the detail-view-fixes branch November 2, 2022 01:56
@andrii-i andrii-i changed the title Add maxWidth, use LabeledValue in Detail View (#2) Create LabeledValue UI element, use LabeledValue in Detail View, fix MaxWidth Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonWeill JasonWeill JasonWeill approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use non-outlined text fields on job details / job definition details page
2 participants
@andrii-i @JasonWeill