Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates directory based on job name, not based on timestamp #206

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

JasonWeill
Copy link
Collaborator

@JasonWeill JasonWeill commented Oct 26, 2022

Fixes #201.

Old file structure, using the filename "stem" and the run timestamp:

jobs/plot-2022-10-26-12-0813-PM/plot.ipynb

New file structure, using the filename stem and the job ID:

jobs/plot-6d56ab09-da11-4599-a503-7c3b43c7e3e1/plot.ipynb

This change also introduces a - delimiter between minutes and seconds above.

@JasonWeill JasonWeill added the bug Something isn't working label Oct 26, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jweill-aws/jupyter-scheduler/directory-name-conflict

Copy link
Collaborator

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @dlqqq also wanted to review this PR so he might have more comments

@3coins 3coins self-requested a review October 27, 2022 23:13
@JasonWeill JasonWeill merged commit 6cb7e6b into jupyter-server:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory name conflict if two jobs have the same input filename
3 participants