Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy create: Create job schedule by minute, hour, day, weekday, week, or month #111

Merged
merged 23 commits into from
Oct 10, 2022

Conversation

JasonWeill
Copy link
Collaborator

@JasonWeill JasonWeill commented Oct 10, 2022

Adds six additional options to schedule a job every minute, every hour at M minutes past the hour, every day at time T, every weekday at time T, every week at time T on day-of-week W, and every month at time T on day-of-month D.

Text inputs are validated. Changes are persisted in the cron schedule format.

Fixes #84, #98, #80.

Screen shots:

every minute

every hour

every day

every week

every weekday

every month

custom schedule

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jweill-aws/jupyter-scheduler/easy-create

Copy link
Collaborator

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and difference in usability is night and day compared to previous scheduling versions.

Overall looks good, left some nit comments.

@JasonWeill JasonWeill merged commit e2f5628 into jupyter-server:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants