Add disk monitoring #232
Add disk monitoring #232
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
I am unclear as to what is failing the linting... everything passes on my workstation |
jupyter_resource_usage/api.py
Outdated
| limits["disk"] = {"disk": disk_info.total} | ||
| if config.disk_warning_threshold != 0: | ||
| limits["disk"]["warn"] = (disk_info.total - disk_info.used) < ( | ||
| disk_info.total * config.cpu_warning_threshold |
There was a problem hiding this comment.
shouldn't this be
disk_info.total * config.disk_warning_threshold??
There was a problem hiding this comment.
Indeed it should!
There was a problem hiding this comment.
Additionally, the warning state calculated is never handled. It looks like the current client-side code handles warning state for memory only. I'm playing with this right now to show the disk warning!
There was a problem hiding this comment.
More than happy for you to contribute....
Question: does the CPU have a parallel warning state that should be handled?
There was a problem hiding this comment.
Great question! I'm more than happy to contribute to your branch and close PR #233, which I've pulled in your changes to and did the React work for the warnings. I was in a flow state this AM and wasn't sure how active this PR was going to be, so I threw those changes together.
Check it out and let me know what you think!
|
This PR has been superseded by #233 |
Adds disk monitoring.
I've also done a couple of tweaks - like moving the UI labelling to indicators to their individual View file, and use these labels as the main reference.
(I didn't try and get the react code to take them from the schema file, but maybe a future task)