-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle currentWidget
in KernelWidgetTracker
#206
Conversation
@jtpio Just to get my head around this, you are saying that when we start a notebook server, the widget has been created and emitted. But only when the user opens a notebook file from the interface, |
I would say it's more that the notebook tracker (which keeps track of all the notebook widgets currently opened on the page - on the frontend) fires This was likely not an issue in JupyterLab because the UI takes more time to initialize and the signal might be emitted multiple times. |
Ok, I see. What I noticed from my tests is that the What you told is coherent with the behavior I observed. Thanks a lot for the explanation @jtpio |
@jtpio Btw, I have noticed that |
yes that would make sense. Would you like to open a PR? |
Sure, will do that! |
Thanks! |
FIxes #204
The tracker now keeps track of the
currentWidget
. This is useful in the case of Notebook 7 where connecting tocurrentChanged
might not be enough. Notebook 7 adds the notebook widget to the page very early, and the kernel usage component might be connecting totracker.currentChanged
after thetracker.currentChanged
is emitted.notebook-7-kernel-usage.mp4