Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pss if available #171

Merged
merged 3 commits into from
Jan 28, 2023
Merged

Use pss if available #171

merged 3 commits into from
Jan 28, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 23, 2023 •
edited
Loading

Fixes #130

@jtpio jtpio mentioned this pull request Jan 23, 2023
Closed
@jtpio jtpio marked this pull request as ready for review January 27, 2023 09:31
krassowski
krassowski approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

jupyter_resource_usage/static/main.js Outdated Show resolved Hide resolved
@jtpio @krassowski
Use the Nullish coalescing operator
52fa6e1 
Co-authored-by: Michał Krassowski <[email protected]>
@krassowski krassowski merged commit 4a7ff2d into jupyter-server:master Jan 28, 2023
@jtpio jtpio deleted the enable-pss branch February 6, 2023 08:46
@krassowski krassowski mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature to change default metrics for memory calculation from RSS to PSS
3 participants
@jtpio @davidbrochart @krassowski