Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the shadow FS initialisation to three attempts #936

Merged

Conversation

krassowski
Copy link
Member

References

Addresses #924 (comment)

Code changes

  • limit the shadow FS initialisation to three attempts
  • emit a warning with suggestions if third attempt fails
  • add a test for permission error

User-facing changes

None unless affected by #924

Backwards-incompatible changes

None

emit a useful warning and add a test for permission error
@krassowski krassowski added the bug Something isn't working label May 6, 2023
@github-actions
Copy link

github-actions bot commented May 6, 2023

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/fix/924-prevent-repetitive-error

@krassowski krassowski force-pushed the fix/924-prevent-repetitive-error branch from 48a3398 to 8e715e3 Compare May 6, 2023 19:00
@krassowski krassowski merged commit 39ee7d9 into jupyter-lsp:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant