Make .virtual_documents optional
#930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
because deployments may primarily use a well-behaved server that does not need virtual documents folder together with secondary servers that do require it but are only used from time to time when opening specific file types. This can also marginally improve startup times as there is no need to wait on file system operation of purging the directory which is now only done on first relevant LSP message.
krassowski
added a commit
to krassowski/jupyterlab
that referenced
this pull request
Jun 18, 2023
Cherry-picked from jupyter-lsp/jupyterlab-lsp#930
fcollonval
pushed a commit
to jupyterlab/jupyterlab
that referenced
this pull request
Jun 22, 2023
* Use proper web socket URL, see jupyter-lsp/jupyterlab-lsp#819 Co-authored-by: Author: MikeSem <[email protected]> * Use app's HTTP settings, cherry-picked from jupyter-lsp/jupyterlab-lsp#882 Co-authored-by: Nicholas Bollweg <[email protected]> * Support optional `.virtual_documents` Cherry-picked from jupyter-lsp/jupyterlab-lsp#930 --------- Co-authored-by: Author: MikeSem <[email protected]> Co-authored-by: Nicholas Bollweg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Closes #537. Related to #924.
Code changes
requires_documents_on_diskfield in the specs (Trueby default for now, will becomeFalsein next major version)language_servers: KeyedLanguageServerSpecsAPI member of the managermanagerargumentUser-facing changes
No
.virtual_documentswhen only using servers which do not require it. If at least one of installed servers requires.virtual_documents, it may still be created, but the creation will be delayed until such a server is actually in use.Backwards-incompatible changes
None