Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overrides.json not being picked up in defaults #919

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Fix overrides.json not being picked up in defaults #919

merged 4 commits into from
Mar 20, 2023

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Mar 19, 2023 •
edited
Loading

References

Fixes #918

Code changes

  • include defaults from overrides (provieded via schema) in composite defaults
  • update/fix pyright schema (addressing warning in check added with above checking for defaults not aligning with schema)

User-facing changes

  • overrides.json will work
  • pyright settings from UI will work

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/overrides-fix

@krassowski krassowski merged commit 0339708 into jupyter-lsp:master Mar 20, 2023
@krassowski krassowski mentioned this pull request Nov 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overrides.json5
1 participant
@krassowski