Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover tooltip not updated after character deletions #867

Merged
merged 6 commits into from
Mar 15, 2023

Conversation

yamaton
Copy link
Contributor

@yamaton yamaton commented Oct 11, 2022

References

Fixes #866

Code changes

Changed EditorAdapter to emit update signals when nontrivial change.removed exists.

User-facing changes

None.

Backwards-incompatible changes

My concern is that the original behavior might have been intentional as was in the comment.

// deletion - ignore

If so, this PR may affect other signal receivers.

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch yamaton/jupyterlab-lsp/fix-uncleared-hover-cache

@yamaton
Copy link
Contributor Author

yamaton commented Oct 17, 2022

FYI: I could reproduce the CI error about jupyter serverextension list in the following minimum environment.

mamba create -c conda-forge -n py37-minimum-test python=3.7 jupyterlab=3.3 jupyter_server
conda activate py37-minimum-test 
jupyter serverextension list

@krassowski
Copy link
Member

My concern is that the original behavior might have been intentional as was in the comment.

I think that the original intent was to avoid triggering completer on deletion, but indeed this is not where this should be handled. I think it is fine to change it - let's give it a try.

@krassowski krassowski merged commit 7b2f81f into jupyter-lsp:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover tooltip not updated after character delections in the document
2 participants