Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky completion tests #861

Merged
merged 2 commits into from
Sep 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions atest/05_Features/Completion.robot
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,11 @@ Completes Correctly With R Double And Triple Colon
[Setup] Prepare File for Editing R completion completion.R
Place Cursor In File Editor At 2 7
Wait Until Fully Initialized
# normally the completion adapter taking time to initialise is not a problem
# but because the token-based completion fallback would break our test example
# if it kicked off we try to avoid it by adding some delay
# TODO remove sleep after migrating to JupyterLab 4.0 native adapters.
Sleep 2s Workaround completion adapter taking some time to initialize
Trigger Completer
Completer Should Suggest .print.via.format
Select Completer Suggestion .print.via.format
Expand All @@ -319,6 +324,8 @@ Shows Documentation With CompletionItem Resolve
[Setup] Prepare File for Editing R completion completion.R
Place Cursor In File Editor At 8 7
Wait Until Fully Initialized
# TODO remove sleep after migrating to JupyterLab 4.0 native adapters.
Sleep 2s Workaround completion adapter taking some time to initialize
Trigger Completer
Completer Should Suggest print.data.frame
# if data.frame is not active, activate it (it should be in top 10 on any platform)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ class JuliaLanguageServer(ShellSpec):
issues="https://github.com/julia-vscode/LanguageServer.jl/issues",
),
install=dict(julia='using Pkg; Pkg.add("LanguageServer")'),
config_schema=load_config_schema(key)
config_schema=load_config_schema(key),
)
2 changes: 1 addition & 1 deletion python_packages/jupyter_lsp/jupyter_lsp/specs/pyright.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ class PyrightLanguageServer(NodeModuleSpec):
yarn="yarn add --dev {}".format(key),
jlpm="jlpm add --dev {}".format(key),
),
config_schema=load_config_schema(key)
config_schema=load_config_schema(key),
)
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ class TypescriptLanguageServer(NodeModuleSpec):
yarn="yarn add --dev {}".format(key),
jlpm="jlpm add --dev {}".format(key),
),
config_schema=load_config_schema(key)
config_schema=load_config_schema(key),
)
2 changes: 1 addition & 1 deletion scripts/lint.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
ROBOCOP_EXCLUDES = [
"empty-lines-between-sections",
"file-too-long",
"if-can-be-used",
"missing-doc-keyword",
"missing-doc-suite",
"missing-doc-test-case",
"todo-in-comment",
"too-long-test-case",
"too-many-arguments",
"too-many-calls-in-keyword",
Expand Down