-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.6.1, update RELEASE.md #86
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Hooray release... But the python rev needs a bump as well, because of the
new server endpoint? Probably just 0.6.1.
Also, as things are getting longer, I think we may wish to separate some
readme content into CHANGELOG.md and CONTRIBUTING.md as things are ramping
up. These also provide a nice "done done" indicator on PRs. We probably
still want to keep the js/py divide for dev info (with cross links), but
should probably have a single root CHANGELOG (which can be checked in
integrity).
somewhat off topic: I've been thinking about making CONTRIBUTING.ipynb a
thing (not here first, unless you're super jazzed): Basically how easy can
you make it to get/keep going? Using ipywidgets to make a little choose
your-own-adventure (e.g os, path name, current pr) and then command runners
with docs for all the dev tasks. Have some conventions (e.g. show all the
package.json commands, if there's ci, show logs) but the make it easy for a
project to add more stuff.
…On Thu, Oct 31, 2019, 09:31 M. Krassowski ***@***.***> wrote:
Merged #86 <https://github.com/krassowski/jupyterlab-lsp/pull/86> into
master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/krassowski/jupyterlab-lsp/pull/86?email_source=notifications&email_token=AAALCRB4UBOU6M7I6S3IDMLQRLM3FA5CNFSM4JHJAYE2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUR7VXYI#event-2759810017>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRB5KVVOGFGVOSJGTK3QRLM3FANCNFSM4JHJAYEQ>
.
|
I did not use the endpoint yet (it is still todo, now added to #85) so no immediate need for Python release yet. I am all for CHANGELOG.md and CONTRIBUTING.md. There is a more pressing problem with me not fully understanding how to do releases now after the lerna/metapackage introduction. I ran |
Ah, yes. This is a common problem in lerna-land. I'll do some looking.
Quick fix, we can either copy it from the root, or just always check in two
copies and check they are the same in integrity.
However, as we add more (optional) stuff, it may make sense for the root
readme to be about the project with a quick start, and have the py/ts
packages have more targeted contents that link to canonical docs for full
details. Still have one CHANGELOG for sanity, though.
…On Thu, Oct 31, 2019, 10:00 M. Krassowski ***@***.***> wrote:
I did not use the endpoint yet (it is still todo, now added to #85
<https://github.com/krassowski/jupyterlab-lsp/issues/85>) so no immediate
need for Python release yet. I am all for CHANGELOG.md and CONTRIBUTING.md.
There is a more pressing problem with me not fully understanding how to do
releases now after the lerna/metapackage introduction. I ran jlpm publish
from jupyterlab-lsp/packages/jupyterlab-lsp and it kind-of worked, but
***@***.***/jupyterlab-lsp is now missing
README file. Could you guide me on how to do this right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/krassowski/jupyterlab-lsp/pull/86?email_source=notifications&email_token=AAALCRDISQDD7CJHCBKQJVDQRLQGBA5CNFSM4JHJAYE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECX372I#issuecomment-548388841>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRAYHQTSP7AQKJR6QRDQRLQGBANCNFSM4JHJAYEQ>
.
On Thu, Oct 31, 2019, 10:00 M. Krassowski ***@***.***> wrote:
I did not use the endpoint yet (it is still todo, now added to #85
<https://github.com/krassowski/jupyterlab-lsp/issues/85>) so no immediate
need for Python release yet. I am all for CHANGELOG.md and CONTRIBUTING.md.
There is a more pressing problem with me not fully understanding how to do
releases now after the lerna/metapackage introduction. I ran jlpm publish
from jupyterlab-lsp/packages/jupyterlab-lsp and it kind-of worked, but
***@***.***/jupyterlab-lsp is now missing
README file. Could you guide me on how to do this right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/krassowski/jupyterlab-lsp/pull/86?email_source=notifications&email_token=AAALCRDISQDD7CJHCBKQJVDQRLQGBA5CNFSM4JHJAYE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECX372I#issuecomment-548388841>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRAYHQTSP7AQKJR6QRDQRLQGBANCNFSM4JHJAYEQ>
.
|
Let's see if I found all the places with the version number.