Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LSP completion transform of path-likes when insertText missing #833

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Aug 23, 2022

References

Fixes #832

Code changes

User-facing changes

Completion of import { Signal } from @lumino/<tab> will work correctly.

Backwards-incompatible changes

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/completion/handle-missing-insertText-in-paths

@krassowski krassowski merged commit 1552c1c into jupyter-lsp:master Aug 23, 2022
@krassowski
Copy link
Member Author

@meeseeksdev please backport to 3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 25, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 1552c1c22c832f33a9c63493d70a72031dd84a59
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #833: Fix LSP completion transform of path-likes when `insertText` missing'
  1. Push to a named branch:
git push YOURFORK 3.x:auto-backport-of-pr-833-on-3.x
  1. Create a PR against branch 3.x, I would have named this PR:

"Backport PR #833 on branch 3.x (Fix LSP completion transform of path-likes when insertText missing)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

krassowski added a commit to krassowski/jupyterlab-lsp that referenced this pull request Aug 26, 2022
…es when `insertText` missing

(cherry picked from commit 1552c1c)
krassowski added a commit that referenced this pull request Aug 26, 2022
Backport PR #833: Fix LSP completion transform of path-likes when `insertText` missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion with missing insertText can get "undefined" value
1 participant