Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade typescript, use composite, remove require usage (76 0️⃣ ) #77

Merged
merged 2 commits into from
Oct 29, 2019

Conversation

bollwyvl
Copy link
Collaborator

This can wait for review until after the next release, but will be the starting point for some additional PRs.

To simplify the changes in step 1 of #76, this prepares things a bit, such that the move into packages will be straight moves, rather than move-and-changes.

Concretely:

  • upgrades typescript to what lab is currently using
    • resolve yarn.lock
    • appeases some empty block lint fails
  • cleans up some imports (use of require, re-exporting of CodeMirror in a few places)
  • add composite: true
  • adds the -b flag to build and watch

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@bollwyvl bollwyvl added this to the 0.7 milestone Oct 28, 2019
@bollwyvl bollwyvl changed the title upgrade typescript, use composite, remove require usage upgrade typescript, use composite, remove require usage (76 0️⃣) Oct 28, 2019
@bollwyvl bollwyvl changed the title upgrade typescript, use composite, remove require usage (76 0️⃣) upgrade typescript, use composite, remove require usage (76 0️⃣ ) Oct 28, 2019
@bollwyvl
Copy link
Collaborator Author

One windows flake, but otherwise good!

@krassowski
Copy link
Member

Okay, the manual Azure Pipelines restart does not work due to https://developercommunity.visualstudio.com/content/problem/784369/rerun-failed-jobs-transitions-task-to-canceled.html.

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Oct 28, 2019 via email

@krassowski
Copy link
Member

It went through smoothly at https://dev.azure.com/krassowskimichal/jupyterlab-lsp/_build/results?buildId=84&view=logs&j=a1481901-c0b1-5ce5-074c-5d9d313a786f. I reviewed this step [0] (no comments) and I'm going to merge it now so we have this in before the presentation.

I am not sure if I want to merge step [1] already or first finish off other PRs and then merge it.
I will take a closer look tonight.

@krassowski krassowski merged commit 21ff0cc into jupyter-lsp:master Oct 29, 2019
@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Oct 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants