-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade typescript, use composite, remove require usage (76 0️⃣ ) #77
upgrade typescript, use composite, remove require usage (76 0️⃣ ) #77
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
…step-0-composite
One windows flake, but otherwise good! |
Okay, the manual Azure Pipelines restart does not work due to https://developercommunity.visualstudio.com/content/problem/784369/rerun-failed-jobs-transitions-task-to-canceled.html. |
Yeah. Bummer. Can you "enqueue new build"? I don't have perms (which is
fine! More looking for more chores) It might not get picked up in gh,
though....
…On Mon, Oct 28, 2019, 16:04 M. Krassowski ***@***.***> wrote:
Okay, the manual Azure Pipelines restart does not work due to
https://developercommunity.visualstudio.com/content/problem/784369/rerun-failed-jobs-transitions-task-to-canceled.html
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/krassowski/jupyterlab-lsp/pull/77?email_source=notifications&email_token=AAALCRFVU3UM2AICYAZNWLTQQ5AVRA5CNFSM4JFU5OUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECOGX4Q#issuecomment-547122162>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRCGJM7FIH42SMI2HZTQQ5AVRANCNFSM4JFU5OUA>
.
|
It went through smoothly at https://dev.azure.com/krassowskimichal/jupyterlab-lsp/_build/results?buildId=84&view=logs&j=a1481901-c0b1-5ce5-074c-5d9d313a786f. I reviewed this step [0] (no comments) and I'm going to merge it now so we have this in before the presentation. I am not sure if I want to merge step [1] already or first finish off other PRs and then merge it. |
Great! The other one is still definitely wip, and doesn't provide any value
(yet) for the presentation, so don't sweat it. If you can't make it to the
show, I'm just planning on running through the examples with some garish
Halloween css (ghosts and pumpkins and stuff). If you can, we can tag team
it, kind of narrative style.
…On Tue, Oct 29, 2019, 09:48 M. Krassowski ***@***.***> wrote:
Merged #77 <https://github.com/krassowski/jupyterlab-lsp/pull/77> into
master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/krassowski/jupyterlab-lsp/pull/77?email_source=notifications&email_token=AAALCRHXGDDQIFHKLLWY5ADQRA5MPA5CNFSM4JFU5OUKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUQFWVJY#event-2752211623>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRCTTMERWX7HS6GZ36LQRA5MPANCNFSM4JFU5OUA>
.
|
To simplify the changes in step 1 of #76, this prepares things a bit, such that the move into
packages
will be straight moves, rather than move-and-changes.Concretely:
yarn.lock
empty block
lint failsrequire
, re-exporting of CodeMirror in a few places)composite: true
-b
flag tobuild
andwatch