Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature blur and fix formatting when no arguments are present #734

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

krassowski
Copy link
Member

References

Follow up after #671:

  • signature (and details) should be clickable but were not due to incorrect use of target where relatedTarget should be used
  • label code was not rendering in signature for functions without arguments if details were present due to a missing new line

Code changes

  • use relatedTarget in blur event
  • always add two new lines if details are, not only when highlighting active arguments

User-facing changes

Before:

before

After:

after

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jupyter-lsp/jupyterlab-lsp/signature-details

@krassowski krassowski merged commit d2ef26c into master Dec 27, 2021
@krassowski krassowski deleted the signature-details branch December 27, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant