Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct gettext method #700

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Correct gettext method #700

merged 1 commit into from
Oct 28, 2021

Conversation

fcollonval
Copy link
Contributor

References

Code changes

Correctly call function with plural support

User-facing changes

Plural messages will correctly be picked for the status bar component.

Backwards-incompatible changes

N/A

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch fcollonval/jupyterlab-lsp/patch-1

@krassowski krassowski enabled auto-merge October 28, 2021 07:13
krassowski
krassowski approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@krassowski krassowski merged commit 1959824 into jupyter-lsp:master Oct 28, 2021
@fcollonval fcollonval deleted the patch-1 branch October 28, 2021 07:24
@krassowski krassowski mentioned this pull request Dec 14, 2021
Closed
@fcollonval fcollonval mentioned this pull request Dec 17, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @krassowski