Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where position is null in document.ts #658

Merged
merged 5 commits into from
Aug 28, 2021

Conversation

bsyouness
Copy link
Contributor

@bsyouness bsyouness commented Aug 9, 2021

References

This fixes issue #543 which #544 fixed partially.

Code changes

Add a check that pos isn't null before trying to access its properties.

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski
Copy link
Member

Thank you! The tests are failing - we do not have a console on object on VirtualDocument. Using plain console would be fine here for now, but if you want to add our custom console wrapper as a protected member of VirtualDocument (should be passed via VirtualDocument.IOptions) please feel free to do so.

@bsyouness
Copy link
Contributor Author

@krassowski I did as per your suggestion and added a custom console as a member of VirtualDocument.

.gitignore Outdated Show resolved Hide resolved
@bsyouness
Copy link
Contributor Author

Should I be concerned about/fix the partial test failures?

@krassowski
Copy link
Member

No, no worries I will take care of those.

@krassowski
Copy link
Member

I opened an issue about this upstream conda-forge/tzlocal-feedstock#17.

@bsyouness
Copy link
Contributor Author

Thank you!

@krassowski krassowski merged commit bbc5651 into jupyter-lsp:master Aug 28, 2021
@krassowski
Copy link
Member

Thank you!

@bsyouness bsyouness deleted the patch-1 branch September 2, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants