-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle case where position is null in document.ts #658
Conversation
Thank you! The tests are failing - we do not have a |
@krassowski I did as per your suggestion and added a custom console as a member of |
Should I be concerned about/fix the partial test failures? |
No, no worries I will take care of those. |
I opened an issue about this upstream conda-forge/tzlocal-feedstock#17. |
Thank you! |
Thank you! |
References
This fixes issue #543 which #544 fixed partially.
Code changes
Add a check that
pos
isn'tnull
before trying to access its properties.Chores