Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize lsp server error message #621

Merged
merged 10 commits into from
Jun 16, 2021

Conversation

icankeep
Copy link
Contributor

@icankeep icankeep commented Jun 7, 2021

References

Fixes #620

Code changes

Optimize lsp server error message

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski
Copy link
Member

Thank you! It looks it needs a prettier pass (the lint check is failing).

@icankeep
Copy link
Contributor Author

icankeep commented Jun 7, 2021

Thank you! It looks it needs a prettier pass (the lint check is failing).

I'll fix it

@krassowski
Copy link
Member

To explain the noise of commits: I had to update some mypy requirements which are not on conda-forge as it seems yet and are also not great to auto-install from CI (python/mypy#10600) but it is all good now.

@krassowski krassowski merged commit ea36f7e into jupyter-lsp:master Jun 16, 2021
@krassowski krassowski added this to the 3.8 milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Server Extension Missing" unless manually enabled in Jupyter Server
2 participants