Switch to python-lsp-server for testing #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bollwyvl
reviewed
Apr 25, 2021
Testing unmaintained version is not worth it as it does not run the newest jedi/IPython stack and would make the CI too fragile
|
Yeah, and it's probably time to drop py3.6 as well as it's ipython won't
work with newer jedi... Would simplify my robot pr, too!
|
krassowski
force-pushed
the
switch-to-pyls-fork
branch
from
b07e37f to
4994f63
Compare
|
Well, the tests work for now - I guess it it install an older version on 3.6. We should certainly drop 3.6 later this year if it is slowing us down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Follow up on #582 fixing Python module name, actually enabling it in tests and changing tests to use it rather than the old Palantir's version.
Code changes
Updated references of
pylstopylsp.User-facing changes
The readme will now recommend installation of pylsp instead of pyls.
Chores